Follow crdt to v0.34.0, where OpsSince learned to refuse - #6
Closed
tannevaled wants to merge 1 commit into
Closed
Conversation
A replica that has collected below where another stands cannot say what that other is missing: what it gave back is not in its differences any more. Merge carries the refusal rather than merging a difference with holes in it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Author
|
No longer needed. crdt v0.35.0 puts OpsSince back to the signature this repository is pinned to — the change that made this necessary was withdrawn (go-crdt/crdt#70). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-crdt/crdtv0.34.0 makesOpsSincereturn an error below the collectionfloor, where it used to hand back a difference with holes in its sequence
numbers that a peer could only park.
Local.Mergeis the one call site here. It carries the refusal: a replica thathas collected below where another stands cannot say what that other is missing.
Such a pair is merged from the other side, or through their snapshots — not by
papering over it.
Nothing in this repository collects, so the refusal cannot happen today; the
change is that it would be reported rather than silently producing a partial
merge.
Suite green,
vetandgofmtclean.