ci: grant publishing permissions to the deploy job only - #11
Merged
Conversation
The workflow-level permissions block applied to every job, so the build that runs on a pull request held a token able to publish the site. Nothing leaked: the deploy job is gated on the branch and a pull request never reaches it. But a pull request build is exactly where third-party code runs -- a dependency resolved during the build, an action at a floating tag -- and it should not run holding a token it has no use for. The publishing grant moves down to the deploy job. The workflow keeps only what the build actually reads. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pull-request build runs third-party code — a dependency resolved during the build, an action at a floating tag — and it should not do so holding a token that can publish the site or write the repository.
Nothing leaked: the deploy step was already gated on the branch. This narrows the grant rather than closing a hole. Publishing rights now sit on the deploy job alone.
Part of a fleet-wide sweep of 545 workflows. Proven first on
go-asmgen/go-asmgen.github.io#7andgo-asmgen/docs#11, where the pull request reportedbuild=success deploy=skippedandmainafter merge reportedbuild=success deploy=success— the narrowed grant still publishes, and a pull request still cannot.