Take the JBIG2 decoder that reads the last seven streams - #29
Merged
Conversation
go-gfx/gfx v0.15.0 takes its JBIG2 decoder from a fork carrying one fix, offered upstream as dkrisman/gobig2#2: the per-symbol pixel cap defaulted to 4 megapixels, below what real scanned documents contain, and a library could not raise it because the limits are process-global variables. Of 403 JBIG2 streams taken from the /Mask and /SMask entries of public Internet Archive scans, 7 were refused at that default. With the fix all 403 decode, every one bit-exact with poppler's own decoder. The dependency also stops being untagged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-gfx/gfx v0.15.0 takes its JBIG2 decoder from a fork carrying one fix, offered upstream as dkrisman/gobig2#2: the per-symbol pixel cap defaulted to 4 megapixels, below what real scanned documents contain, and a library could not raise it because the limits are process-global variables.
Of 403 JBIG2 streams taken from the
/Maskand/SMaskentries of public Internet Archive scans, 7 were refused at that default. With the fix all 403 decode, every one bit-exact with poppler's own decoder.The dependency also stops being untagged.
100% statement coverage,
go vetand-raceclean, nine cross-compile targets.