engine: take go-tex/math v0.25.0 (inline \def expands in the mouth) - #190
Merged
Conversation
v0.25.0 teaches the math layer to expand a \def written INSIDE a formula rather than dropping the equation on the unknown command. Honest scope: the measured corpus impact is negligible — across the 200 arXiv reference papers, output is byte-identical on all but one (2311.02037, +2 glyphs), with no regression. That is expected: the engine's own math-macro retry already substitutes preamble- and body-level \def/\newcommand before the math layer runs, so only a \def appearing literally inside a formula's source — which the corpus essentially never does — reaches this new path. This is a correctness/robustness bump keeping the dependency current, not a parity win. Verified: full engine suite green on v0.25.0; the two papers whose skipped-count shifted were confirmed byte-identical (2205.03780) or a small real gain (2311.02037) by comparing rendered glyph output, not the misleading drop count. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
go-tex/mathv0.24.0 → v0.25.0 (go-tex/math#10), which expands a\defwritten inside a formula instead of dropping the equation.Honest scope — a correctness bump, not a parity win
Measured across the 200 arXiv reference papers: output is byte-identical on all but one (2311.02037, +2 glyphs), no regression. That's expected — the engine's own math-macro retry already substitutes preamble- and body-level
\def/\newcommandbefore the math layer runs, so only a\defappearing literally inside a formula's source reaches the new path, which the corpus essentially never does.I verified the two papers whose skipped-count shifted by comparing rendered glyph output (the drop count is misleading): 2205.03780 is byte-identical (37 pages, 64,111 glyph-paths both ways); 2311.02037 gains 2 glyphs. Full engine suite green. Diff is
go.mod/go.sumonly.Completes the lockstep for the
\deflibrary feature; I'm flagging the negligible corpus impact plainly rather than overclaiming.🤖 Generated with Claude Code