feat: follow Label/Button text to MVVM accessors (toolkit v0.223.0) - #19
Merged
Conversation
toolkit v0.223.0 moved Label text and Button label/selected state onto mvvm.Observable accessors. Recable the two write sites in cmd/gwapp (Label.Text field write -> Text().Set) and bump toolkit to v0.223.0, mvvm to v0.8.0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toolkit v0.223.0 moved Label text and Button label/selected state onto
mvvm.Observableaccessors. This recables the two write sites the compiler flagged — bothLabel.Textfield writes incmd/gwapp(click counter, touch-floor hit counter) — toText().Set(...), and bumps deps: toolkit v0.201.0 → v0.223.0, mvvm v0.7.0 → v0.8.0.Verified:
GOWORK=off go build ./...+go vet ./...greenCGO_ENABLED=0 GOOS=android GOARCH=arm64 go build ./...green (CI's APK gate)GOWORK=off go test ./... -covergreen, root package 97.8% (unchanged; edits are incmd/gwapponly)gofmt -l .empty🤖 Generated with Claude Code