application: take tray v0.7.1, where what the tray shows is locked - #1
Merged
Conversation
The icon, the tooltip and the menu were plain fields in tray: the platform loop reads all three to draw them, and an application changing its menu when its state changes writes them from wherever that state lives. The race detector caught it in another consumer; on a Mac it is the AppKit main loop reading a slice header another goroutine is replacing. Nothing here changes shape -- the upgrade is additive -- but every application built on this package gets the fix, which is the reason this package exists to be upgraded once instead of each of them separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tray'sicon,tooltipandmenuwere plain fields. The platform loop reads all three to draw them, and an application that changes its menu when its state changes writes them from wherever that state lives. The race detector caught it in another consumer (go-xrkit/desk, throughtray.BindIcon); on a Mac it is the AppKit main loop reading a slice header another goroutine is replacing.trayv0.7.1 puts them behind anRWMutex.Nothing here changes shape — the upgrade is additive — but every application built on this package gets the fix, which is the reason this package exists to be upgraded once rather than each of them separately.
Tests pass, including under
-race.