feat(foldertabs): optional per-tab leading Icons - #432
Merged
Conversation
FolderTabs took only string labels, so a host could not give a tab a glyph. Add an optional Icons []IconFunc slice, parallel to Labels: a non-nil entry at index i draws a leading glyph before that tab's caption and widens the tab to fit it. A short or nil slice leaves those tabs icon-less, so a FolderTabs that never sets Icons draws exactly as before. Icons is a set-once appearance field (added to the widget's MVVM allowlist, like Labels). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FolderTabstook only string labels, so a host could not give a tab a glyph. Add an optionalIcons []IconFuncslice, parallel toLabels: a non-nil entry at index i draws a leading glyph before that tab's caption and widens the tab to fit it. A short or nil slice leaves those tabs icon-less, so aFolderTabsthat never setsIconsdraws exactly as before (added to the widget's MVVM allowlist, likeLabels). Pixel-tested; 100% coverage gate green.