Bump gfx: the document's own stroke and fill properties - #437
Merged
Conversation
gfx/svg was ignoring six inherited paint properties, and reached its stroker through a convenience call that hardcoded round caps and joins. Iconoir asks for round everywhere, so SVGIcon looked correct and the substitution was invisible; any pack that omits stroke-linecap - butt, per the spec - was being rounded. go-gfx/gfx#34 wires fill-rule, fill-opacity, stroke-opacity, stroke-linecap, stroke-linejoin, stroke-miterlimit, stroke-dasharray and stroke-dashoffset, all against the SVG 1.1 property index and resvg's conformance corpus. rougelex is tidied in the same commit: it replaces the parent with ../, so a dependency change here leaves its own go.mod stale and go vet refuses. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gfx/svgwas ignoring six inherited paint properties, and reached its stroker through a convenience call that hardcodesCap: RoundCap, Join: RoundJoin. Iconoir asks for round on every path, soSVGIconlooked correct and the substitution stayed invisible — but any pack omittingstroke-linecap(butt, per the spec) was being silently rounded.go-gfx/gfx#34 wires
fill-rule,fill-opacity,stroke-opacity,stroke-linecap,stroke-linejoin,stroke-miterlimit,stroke-dasharrayandstroke-dashoffset, taking semantics and edge cases from the SVG 1.1 property index and resvg's conformance corpus rather than from guesswork. Released as v0.19.0.Iconoir renders identically (14.1% coverage at 8×) — its round caps now come from the file.
rougelexis tidied in the same commit: it carriesreplace github.com/go-widgets/toolkit => ../, so any dependency change in the parent leaves its go.mod stale andgo vetrefuses. Its lane is the only thing that catches it.gofmt clean, vet, tests, and rougelex's own gate all pass.
🤖 Generated with Claude Code