Correct the docs: the VST3 plugin is complete and validates - #10
Merged
Conversation
The README and WIKI still described the danzig-gain factory as a stub that produces zero classes. That has not been true since the factory was implemented (commit a6a3ff5). Verified now: `zig build vst3` builds the universal bundle, and pluginval passes at strictness level 5, "Num plugins found: 1", 19 test groups, no failures. The integration harness runs about fifty checks through the C ABI, including createInstance, the interface queries, the bus and parameter reports, and a full setupProcessing / process pass checked against the DSP. Updated to match reality: - README and WIKI "Current state": the plugin loads, instantiates, and passes pluginval, with the real SUCCESS output rather than the old FAILURE block. - WIKI "Load it in a DAW" and the "DAW does not list the plugin" troubleshooting entry: rewritten from "expected today, reports no classes" to genuine rescan / cache guidance. - danzig-test README and the WIKI harness section: the checks list and sample output now reflect the ~50-check lifecycle coverage, not the old six-line factory-only list. "What it does not check" now names 64-bit processing and the editor view, both declined on purpose. - CI note corrected to 0.14.1, 0.15.2, and 0.16.0. No code changed. This is a documentation correction backed by a fresh pluginval run and the integration harness. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
godofecht
added a commit
that referenced
this pull request
Jul 29, 2026
The README and WIKI still described the danzig-gain factory as a stub that produces zero classes. That has not been true since the factory was implemented (commit a6a3ff5). Verified now: `zig build vst3` builds the universal bundle, and pluginval passes at strictness level 5, "Num plugins found: 1", 19 test groups, no failures. The integration harness runs about fifty checks through the C ABI, including createInstance, the interface queries, the bus and parameter reports, and a full setupProcessing / process pass checked against the DSP. Updated to match reality: - README and WIKI "Current state": the plugin loads, instantiates, and passes pluginval, with the real SUCCESS output rather than the old FAILURE block. - WIKI "Load it in a DAW" and the "DAW does not list the plugin" troubleshooting entry: rewritten from "expected today, reports no classes" to genuine rescan / cache guidance. - danzig-test README and the WIKI harness section: the checks list and sample output now reflect the ~50-check lifecycle coverage, not the old six-line factory-only list. "What it does not check" now names 64-bit processing and the editor view, both declined on purpose. - CI note corrected to 0.14.1, 0.15.2, and 0.16.0. No code changed. This is a documentation correction backed by a fresh pluginval run and the integration harness. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The danzig README and WIKI still described the
danzig-gainfactory as a stub producing zero classes. That has not been true since the factory was implemented (commita6a3ff5). This corrects the record.Verified now
19 pluginval test groups, 0 failures. The
danzig-testintegration harness runs ~50 checks through the raw C ABI:createInstance, the interface queries, bus and parameter reports, and a fullsetupProcessing/setActive/processpass whose output is checked against the DSP (0 dB unity, +6 dB ~1.995, bypass passthrough).zig build testis 35/35 plus the harness.Doc changes (no code)
danzig-testREADME and the WIKI harness section: checks list and sample output now reflect the ~50-check lifecycle coverage. "What it does not check" now names 64-bit processing and the editor view, both declined on purpose.🤖 Generated with Claude Code