[Android] Add initial AccessKit support. - #117785
Conversation
2ce37f2 to
9de386d
Compare
Should be fixed now. |
fadcf2b to
7f1c68f
Compare
|
@bruvzg I got another crash testing your latest changes, this time after turning off talkback while the Android editor was still running. Screen_Recording_20260813_105655_Settings.mp4 |
I was not able to reproduce it on the phone interface, might be specific to multi-window environment (or inconsistent), I will check it on weekend. |
From the log, the crash occurs after a hover event so that may be hard to reproduce on a phone without a connected mouse or stylus to generate a hover event. |
|
Still was not able to reproduce the crash on any device (neither with touch, not with scrcpy emulated mouse, nor with directly connected mouse). Will try emulator later. |
|
@bruvzg Any updates on this PR? Were you able to reproduce the crash? |
|
I was not able to reproduce the crash, neither on simulator nor on real devices. |
|
@bruvzg The issue is replicable on the Android simulator, however you need to use the Desktop AVD instead of the regular Phone / Tablet because those ones don't dispatch hover events. You can check out these instructions for how to setup the Desktop AVD. repro_accesskit_crash_desktop_avd.webm |
Nothing in this PR should need changing, we use separate repo for custom AccessKit builds - https://github.com/godotengine/godot-accesskit-c-static I'll test it on Saturday (and update our custom build repo). |
# Conflicts: # .github/workflows/android_builds.yml # Conflicts: # platform/linuxbsd/detect.py # Conflicts: # main/main.cpp
|
I have tested it with desktop AVD, and was able to reproduce the crash. I can confirm it is fixed by AccessKit/accesskit#803 To avoid version mismatches, I'll probably wait for next official accesskit-c release before updating our custom build repo. It will also require a tiny, non-platform specific change to the main repo due to API renames, I will do a separate follow-up PR once it is updated. Should not really matter if this part is done before freeze or not, since AccessKit version update is not a new feature. |
|
Thanks! |
|
accesskit-c 0.23.1 released. It contains a few fixes and improvements for Android, including the one discussed here. |
Adds support for screen reader on Android using
AccessKit.Screen.Recording.2026-08-12.at.11.09.48.mov