vulkan: Regenerate host cereal to use GFXSTREAM_ERROR - #193
Merged
Merged
Conversation
GOOG-sergiu
force-pushed
the
cereal_error_logging
branch
from
September 29, 2026 11:47
1685271 to
814e37e
Compare
Regenerate host cereal dispatch and marshaling sources with updated Mesa codegen to route errors through GFXSTREAM_ERROR and GFXSTREAM_FATAL instead of fprintf. Include "gfxstream/common/logging.h" in goldfish_vk_private_defs.h to provide GFXSTREAM_ERROR definitions for cereal compilation.
kocdemir
reviewed
Sep 29, 2026
GOOG-sergiu
force-pushed
the
cereal_error_logging
branch
from
September 29, 2026 13:58
814e37e to
e8f2f35
Compare
kocdemir
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerate host cereal dispatch and marshaling sources with updated Mesa codegen to route errors through GFXSTREAM_ERROR instead of fprintf.
Include "gfxstream/common/logging.h" in goldfish_vk_private_defs.h to provide GFXSTREAM_ERROR definitions for cereal compilation.
Corresponding mesa MR
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/44771