Refactor weather-sp for adding recursive copy files#552
Open
shail-parekh wants to merge 6 commits into
Open
Conversation
Piyush-Ingale
requested changes
Jul 16, 2026
j9sh264
requested changes
Jul 20, 2026
| copy_dir(tmpdir, prefix) | ||
| self.logger.info('Finished uploading %r', self.input_path) | ||
| else: | ||
| raise RuntimeError( |
Collaborator
There was a problem hiding this comment.
Is it advisable to raise a RuntimeError for this? As this does not specifically mean it's a pipeline issue/bug.
Thoughts @Piyush-Ingale @mahrsee1997 ?
Collaborator
There was a problem hiding this comment.
Yes, we could raise a ValueError. Alternatively, we could log it as an error to prevent the entire pipeline from crashing if a failure occurs while generating split files for only one of the input files.
Collaborator
There was a problem hiding this comment.
Agreed then let's log it as an error or a warning
shail-parekh
force-pushed
the
modify-weather-sp-for-copy-files
branch
from
July 20, 2026 12:43
804824f to
f8e8273
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor copy_dir for robust GCS uploads
gcloud storage cp -rwith explicit file lists.