test(bigtable): adopt run-test runner for bigtable - #9477
Merged
danieljbruce merged 1 commit intoSep 30, 2026
Merged
Conversation
Contributor
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the test scripts in handwritten/bigtable/package.json (snippet-test, system-test, and test) to execute using a custom test runner script node ../../bin/run-test.cjs instead of calling mocha or c8 mocha directly. There are no review comments, and I have no feedback to provide.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the test scripts in handwritten/bigtable/package.json to run via a centralized test runner script (node ../../bin/run-test.cjs). Feedback on these changes points out that replacing c8 mocha with the new runner in the test script removes code coverage reporting, and suggests wrapping the new command with c8 to restore it.
quirogas
approved these changes
Sep 30, 2026
danieljbruce
deleted the
bun-runtime/1-test-runner-handwritten-libraries-4-2
branch
September 30, 2026 17:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test,system-test, andsnippet-testscripts inhandwritten/bigtable/package.jsonto invokebin/run-test.cjsinstead of callingmocha/c8 mochadirectly.No additional library or test changes were necessary because the
proxyquirerequire shim (bin/proxyquire-bun-shim.cjs) already handles module stubbing and cache isolation across Bigtable's unit test suite under Bun. Additionally, the introduction of the--exitflag inbin/run-test.cjsensures the test runner terminates cleanly after tests complete despite background OpenTelemetry metric timers and gRPC mock server handles.Impact
This change enables the
@google-cloud/bigtabletest suites to run seamlessly under both the Node.js and Bun runtimes via the centralizedbin/run-test.cjstest runner.Testing
bun --bun run testinhandwritten/bigtableand verified that all unit tests pass under the Bun runtime.node ../../bin/run-test.cjs.