Make Grafana a standalone application - #850
Open
methylDragon wants to merge 1 commit into
Open
Conversation
methylDragon
force-pushed
the
ch3/standalone-grafana
branch
2 times, most recently
from
August 7, 2026 08:54
b1d6d81 to
4cdbad3
Compare
methylDragon
requested review from
csieber,
ensonic and
vivekbagade
and removed request for
ensonic
August 7, 2026 08:57
ensonic
approved these changes
Aug 7, 2026
ensonic
left a comment
ensonic
left a comment
Contributor
There was a problem hiding this comment.
I like that! We should have probably done that from the start. We're you able to test deploy this on a personal-dev project?
Contributor
|
@awhdesmond just FYI |
Contributor
Author
See test process in https://github.com/intrinsic-ai/insrc/pull/51993 |
methylDragon
commented
Aug 7, 2026
Contributor
Author
There was a problem hiding this comment.
MERGE AFTER:
methylDragon
force-pushed
the
ch3/standalone-grafana
branch
from
August 9, 2026 09:06
4cdbad3 to
111caa8
Compare
awhdesmond
approved these changes
Aug 10, 2026
awhdesmond
left a comment
awhdesmond
left a comment
Contributor
There was a problem hiding this comment.
Small nit: to remove
- description: Grafana Dashboard
url: "https://{{ .Values.domain }}/grafana/"
in prometheus app.yaml
methylDragon
force-pushed
the
ch3/standalone-grafana
branch
from
August 12, 2026 20:12
111caa8 to
5e2c121
Compare
Heet852003
added a commit
to Heet852003/core
that referenced
this pull request
Aug 12, 2026
Dropped our own standalone grafana app, using the real implementation from googlecloudrobotics#850 instead - kube-prometheus-stack with everything disabled except grafana, which correctly bundles the default k8s dashboards we were missing with a standalone injection. Also picked up the more complete prometheus operator mechanism - native containers/volumes/volumeMounts/serviceAccount.annotations injection (same pattern we built for vmagent), and remoteWrite moved from a flat string to a real structured list. Removed two leftover prometheus/cloud/grafana files that had moved to grafana/cloud but still referenced deleted values - caught via a real build failure. Fixed a stray grafana link in prometheus app.yaml too. Full build across every app passes clean. externalLabels/nodeSelector/ tolerations logic all still intact, nothing of ours lost.
Heet852003
added a commit
to Heet852003/core
that referenced
this pull request
Aug 12, 2026
New standalone victoriametrics-robotmetrics app (robot-metrics cluster: vminsert/vmselect/vmstorage/vmalert, robot vmagent selector) and victoriametrics-cloudmetrics app (cloud-metrics cluster). Both fully configurable - per-component replica count, consolidated upstream sidecar/remote-write config as real structured YAML, remote_write_labels and GCP service account annotation support for Cloud Ops' Mimir integration. Enable/disable per Brandon's review - controlled via AppRollout robots:/cloud: block presence, not explicit flags. Built on top of the standalone Grafana app (googlecloudrobotics#850) rather than a separate implementation - kube-prometheus-stack based, correctly bundles default Kubernetes dashboards a standalone injection would miss. Verified via render at every step throughout development; live deployment on xfa-awesome-alpha - both VictoriaMetrics clusters Ready/Settled, real data confirmed queryable end to end, zero regression to existing Prometheus setup. --no-verify: repo-wide embedmd hook flagging an unrelated pre-existing markdown file, not one of the 43 files in this commit - confirmed via git diff --cached --name-only.
Heet852003
added a commit
to Heet852003/core
that referenced
this pull request
Aug 13, 2026
Two new apps - victoriametrics-robotmetrics (robot-metrics cluster, vminsert/vmselect/vmstorage/vmalert plus the robot vmagent) and victoriametrics-cloudmetrics (cloud-metrics cluster). Both configurable - per-component replica count, upstream sidecar/remote-write config as real structured YAML, service account annotation and dedup labels for Cloud Ops' Mimir integration. Enable/disable controlled via AppRollout block presence, not explicit flags, per review. Built on top of the standalone Grafana app (googlecloudrobotics#850) instead of a separate implementation. Also swapped kube-state-metrics and node-exporter from standalone vendored charts to kube-prometheus-stack, same reasoning - avoids missing default config a standalone injection risks. Found a real gap doing this: our old node-exporter mirror was missing a cardinality-drop rule Prometheus actually applies, fixed as part of the swap. Verified via render throughout. Live on xfa-awesome-alpha, both clusters healthy, zero regression to existing Prometheus.
methylDragon
force-pushed
the
ch3/standalone-grafana
branch
from
August 14, 2026 00:53
5e2c121 to
66ae529
Compare
Heet852003
added a commit
to Heet852003/core
that referenced
this pull request
Aug 14, 2026
Two new apps - victoriametrics-robotmetrics (robot-metrics cluster, vminsert/vmselect/vmstorage/vmalert plus the robot vmagent) and victoriametrics-cloudmetrics (cloud-metrics cluster). Both configurable - per-component replica count, upstream sidecar/remote-write config as real structured YAML, service account annotation and dedup labels for Cloud Ops' Mimir integration. Enable/disable controlled via AppRollout block presence, not explicit flags, per review. Built on top of the standalone Grafana app (googlecloudrobotics#850) instead of a separate implementation. Also swapped kube-state-metrics and node-exporter from standalone vendored charts to kube-prometheus-stack, same reasoning - avoids missing default config a standalone injection risks. Verified via render throughout. Live and verified end to end on xfa-awesome-alpha, both clusters healthy, real robot data confirmed flowing through the full write path. --no-verify: local pre-commit hook failed before commit because buildifier is not on PATH and embedmd flagged a repo-wide markdown file; the full app manifest build below is the validation for this rerebase.
methylDragon
force-pushed
the
ch3/standalone-grafana
branch
2 times, most recently
from
August 19, 2026 02:16
b85564d to
288f0be
Compare
Extract Grafana from the Prometheus application, enabling it to be
deployed and managed independently.
#### Why
Previously, Grafana was deployed as a component of the Prometheus
operator chart, which tightly coupled its lifecycle and configuration
to Prometheus. This change decouples Grafana, allowing for:
- **Independent Management:** Grafana can now be configured, deployed,
and updated separately from Prometheus.
- **Clearer Ownership:** Grafana resources are now owned by its own
dedicated application definition.
- **Reduced Conflicts:** Explicitly disables Grafana within the
Prometheus chart and ensures CRD ownership is handled correctly,
preventing resource conflicts.
#### The code changes include:
- Adding a new `grafana` application definition under `src/app_charts`.
- Moving Grafana's HTTPRoute and Ingress configurations to the new app.
- Configuring the standalone Grafana to use the `kube-prometheus-stack`
Helm chart, but with only Grafana components enabled.
- Disabling Grafana within the `prometheus` application's chart.
Signed-off-by: methylDragon <methylDragon@intrinsic.ai>
methylDragon
force-pushed
the
ch3/standalone-grafana
branch
from
August 19, 2026 21:44
288f0be to
adff071
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract Grafana from the Prometheus application, enabling it to be deployed and managed independently.
!!! Merge AFTER (context):
Why
So Grafana becomes a cross cutting concern, used by Prometheus and (soon to be) VictoriaMetrics
Previously, Grafana was deployed as a component of the Prometheus operator chart, which tightly coupled its lifecycle and configuration to Prometheus. This change decouples Grafana, allowing for:
and updated separately from Prometheus.
dedicated application definition.
Prometheus chart and ensures CRD ownership is handled correctly,
preventing resource conflicts.
The code changes include:
grafanaapplication definition undersrc/app_charts.kube-prometheus-stackHelm chart, but with only Grafana components enabled.
prometheusapplication's chart.