feat(samples): add advanced place details and search samples - #1647
Merged
Conversation
…n advanced details
|
Here is the summary of changes. You are about to add 30 region tags.
This comment is generated by snippet-bot.
|
…s for advanced place list demo
…s per AdvancedPlaceListElement parser behavior
…dmarks rather than dummy placeholder data
SamC12345
approved these changes
Aug 27, 2026
Change-Id: I8fcdb3b6d1babe4b18daa0fcd3c903c39d812332
willum070
approved these changes
Aug 27, 2026
willum070
left a comment
willum070
left a comment
Collaborator
There was a problem hiding this comment.
Code Review / Minor Fixes Summary:
Great work on these new UI Kit samples! I just pushed a single batched commit to the branch to clean up a few TypeScript and ESLint warnings so we don't have to bypass the linters.
Here is a quick breakdown of what was updated across the 5 samples:
- Enforced Strict TypeScript (No more
anyor@ts-nocheck): Ripped out theeslint-disableand@ts-nocheckcomments across allindex.tsfiles. Because some of the newer web components aren't fully natively typed in the global map yet, I added explicit generic types to thequerySelectorcalls (e.g.,document.querySelector<HTMLElement & { places: ... }>instead of casting toany). - HTML Attributes vs. JS Properties: In a few places, the code was assigning a string (the place ID) directly to a JS property that expects a full
Placeobject (likeplaceRequest.place = event.placeId). I swapped these to use.setAttribute('place', \places/${event.placeId}`). This keeps TS happy and automatically prepends the requiredplaces/` resource name prefix! - Event Listener Safety: Fixed a few minor event typings. For example, in
place-list, thegmp-errorlistener was throwing a TS error becausee.detaildoesn't exist on a standard DOMEvent. I cast it to aCustomEventand swapped a logical OR (||) to a nullish coalescing operator (??) to satisfy ESLint. Also added strict truthy checks forevent.placeIdto satisfy template literal rules. - Housekeeping: Updated the copyright headers to 2026 and ran
prettier --writeacross the board so the build runs completely green.
Change-Id: I86ce791b91ada99b429dfc1ab08a8e917ed5b3bb
…emo to illustrate element suppression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added samples for Advanced Place Details, Advanced Place Details Compact, Advanced Place Search Text, and Advanced Place Search Nearby based on their existing Essentials counterparts.