Skip to content

DeleteEdge: remove tail from parent list of head vertex #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svrana wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DeleteEdge: remove tail from parent list of head vertex #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions dag.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,11 @@ func (d *DAG) DeleteEdge(tailVertex *Vertex, headVertex *Vertex) error {
tailVertex.Children.Remove(childVertex)
}
}
for _, parentVertex := range headVertex.Parents.Values() {
if parentVertex == tailVertex {
headVertex.Parents.Remove(parentVertex)
}
}

return nil
}
Expand Down
10 changes: 10 additions & 0 deletions dag_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,16 @@ func TestDAG_DeleteEdge(t *testing.T) {
if size != 0 {
t.Fatalf("Dag expected to have 0 edges but got %d", size)
}

outDegree := vertex1.OutDegree()
if outDegree != 0 {
t.Fatalf("Vertex %s expected to have 0 outgoing edges but got %d", vertex1.ID, outDegree)
}
inDegree := vertex2.InDegree()
if inDegree != 0 {
t.Fatalf("Vertex %s expected to have 0 incoming edges but got %d", vertex2.ID, inDegree)
}

}

func TestDAG_GetVertex(t *testing.T) {
Expand Down