test: add per-event retry/backoff examples for framework#1529 - #138
Merged
Conversation
added 2 commits
August 3, 2026 12:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BroadcastTries()sets the max attempts andBroadcastBackoff()sets the delay before each retry, overriding the queue worker's globaltriesdispatchPublicnow honorsshould_fireinstead of always dispatching, and feature tests pin queue-option forwarding for public/presence channels plus theshould_fire=falseskip pathWhy
This example PR covers goravel/framework#1529, which lets each queued broadcast event opt into its own queue policy instead of inheriting the queue worker's globals.
TeamPresenceBroadcastnow implements all seven optional broadcast interfaces (BroadcastQueue,BroadcastConnections,BroadcastQueueConnection,BroadcastDelay,BroadcastTimeout,BroadcastTries,BroadcastBackoff), and the dispatch controller shares a singlequeueOptions()helper so public and presence dispatches forward the same options the private path already did. The demo pages no longer restrict tries/backoff to the private channel, so every channel type can be configured from the UI.Previously
dispatchPublichardcodedShouldFire: trueand only the private path forwarded queue options, so public/presence broadcasts couldn't be skipped or tuned per event.dispatchPublicnow honorsshould_fire(with a negative-path test asserting nothing is queued), and the feature tests assert dispatch-time serialization for the new forwarding:Note on dependencies: the framework is pinned to the PR-head pseudo-version
v1.18.1-0.20260802085640-2aa82fd133a7(resolvesrefs/pull/1529/head), since per-event retry/backoff is only available on the unreleased framework PR head. This should be swapped for a tagged release once goravel/framework#1529 merges; it also brings transitive bumps (grpc 1.82.1,mimetype 1.4.15,go-runewidth 0.0.27,golang.org/x/exppseudo-version).