Add tests for center/right alignment for above-lines text - #431
Open
lbssousa wants to merge 10 commits into
Open
Add tests for center/right alignment for above-lines text#431lbssousa wants to merge 10 commits into
lbssousa wants to merge 10 commits into
Conversation
tests/gabc-gabc/glyphs and tests/gabc-output/glyphs are symlinks to tests/gabc-dump/glyphs, so the .gabc added there in the gabc-dump commit was already being exercised as a gabc-gabc round-trip test and a gabc-output compile+render smoke test, just without expectations. Add the missing .exp and .pdf, generated and accepted via the harness.
Running the full test suite against fix-1768 surfaced three unrelated, pre-existing tests whose expectations were stale: - gabc-gtex/bugs/fix-42-f.tex: \GreSetTextAboveLines's signature change (text -> alignment,text) affects any fixture using above-lines-text. - gabc-gabc/bugs/fix-42-f.exp, gabc-gabc/glyphs/above_lines_text.exp, gabc-gabc/glyphs/clear.exp: gabc-write.c never serialized syllable- level <alt>...</alt> back to gabc on develop -- a pre-existing bug (the tag was silently dropped on a gabc->gabc round trip) that the above-lines-text-alignment feature's gabc-write.c change fixes as a side effect, since it needed to add that missing code path anyway to also emit the alignment suffix. These three fixtures documented the old (buggy) behavior; regenerated and accepted via the harness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goes with gregorio-project/gregorio#1769.