Skip to content

feat(traits): build a saved trait no attached instance accounts for - #5591

Merged
collindutter merged 1 commit into
fix/minmax-multiline-ui-optionfrom
feat/build-a-saved-trait
Sep 22, 2026
Merged

collindutter merged 1 commit into
fix/minmax-multiline-ui-optionfrom
feat/build-a-saved-trait

Conversation

@collindutter

@collindutter collindutter commented Sep 18, 2026

Copy link
Copy Markdown
Member

A saved parameter may have no trait instance for state to reach, such as an editor-added or runtime-grown parameter. Saved entries now identify the trait class, using stable library namespaces for dynamically loaded modules:

{
    "trait_name": "Options",
    "trait_module": "griptape_nodes.traits.options",
    "trait_state": {"choices": ["sdxl", "flux"]},
}

The loader updates a matching instance or constructs the named trait with its saved constructor state.

@collindutter
collindutter added this pull request to stack #5592 September 18, 2026 22:23
@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.78571% with 26 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ptape_nodes/retained_mode/managers/node_manager.py 67.10% 25 Missing ⚠️
src/griptape_nodes/traits/trait_resolver.py 96.55% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@collindutter
collindutter force-pushed the feat/build-a-saved-trait branch 3 times, most recently from 6b75c7b to bd1d0fe Compare September 22, 2026 20:42
@collindutter
collindutter force-pushed the feat/build-a-saved-trait branch from bd1d0fe to 26a65ae Compare September 22, 2026 22:55
Base automatically changed from fix/trait-state-reaches-the-trait to fix/minmax-multiline-ui-option September 22, 2026 22:55
@collindutter
collindutter merged commit 26a65ae into main Sep 22, 2026
3 of 4 checks passed
@collindutter
collindutter deleted the feat/build-a-saved-trait branch September 22, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant