fix(velocity): never transfer players who are inside a round - #69
Merged
Conversation
The drain deadline used to transfer everyone left, ending rounds early. Players inside a round now stay put: either the round finishes within the grace period and the lobby connect becomes the transfer, or the pod's termination ends the session — the same outcome a forced transfer would have produced, without yanking anyone out of a running round.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operator decision: a drain must not end rounds. The deadline pass now transfers only players who are not inside a round; in-round players stay until the round ends (then the normal drain transfer catches them at the lobby connect) or the pod terminates. Follow-up to #66.