Conversation
Spec addendum: side-keyed classes stay physical in full; centering needs no exception; SidebarInset margins map like upstream; shared srcedit. Claude-Session: https://claude.ai/code/session_019u7BSQ2Kt9bkwzAXN9hGwv
Adds the logical transform-origin utilities the transform emits, and a NativeSelect to the Arabic login demo with a Playwright assertion that its chevron sits at the logical end. Claude-Session: https://claude.ai/code/session_019u7BSQ2Kt9bkwzAXN9hGwv
Drawer names its physical-placement prop `direction`, after vaul's API, so its class-list arms were being logicalised while Sheet's and Sidebar's stayed physical. Both identifiers now count as placement. Claude-Session: https://claude.ai/code/session_019u7BSQ2Kt9bkwzAXN9hGwv
vaul spells the drawer's physical side as its own data attribute, the role data-[side=…] plays elsewhere, so tokens carrying that variant stay physical in full rather than having their borders and radii logicalised. Claude-Session: https://claude.ai/code/session_019u7BSQ2Kt9bkwzAXN9hGwv
…e, error context and sweep hardening Claude-Session: https://claude.ai/code/session_019u7BSQ2Kt9bkwzAXN9hGwv
…weep follow it Claude-Session: https://claude.ai/code/session_019u7BSQ2Kt9bkwzAXN9hGwv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32
What
Adopts shadcn/ui's RTL model. The registry stays physical; a project opts in and gets logical direction classes in what it vendors.
"rtl": trueingsxui.json(gsxui init --rtl). With it,gsxui addandgsxui applypass every vendored.gsx(andinitthe composedstyle.css) throughinternal/rtl. Without it, vendoring is byte-identical to today.gsxui migrate rtlrewrites components vendored before opting in, in place, keeping your edits, idempotently, through the journaled transaction so managed hashes move with the content.internal/rtlcarries upstream'stransform-rtl.tstable verbatim (Classes), rewrites class literals in gsx source by byte offset then formats (GSX), and rewrites@applylists (CSS).internal/srceditis the shared edit applier, extracted from stylegen.switch sideand Drawerswitch directionarms, Sidebar's[data-side=…]rail border, Drawer'sdata-[vaul-drawer-direction=…]variants. This is wider than upstream's positioning-only skip and matches the existing physical-side rulingrtl.spec.tspins.site/uirtlpackage (upstream does the same withui-rtl), so the RTL page shows the transform's real output. The login demo gained aNativeSelectwith a Playwright assertion that its chevron sits at the logical end, the symptom RTL: physical direction classes remain in ~15 components (RTL page says logical) #32 reported.foundation.cssgainsorigin-top-startand five siblings, which the transform emits and Tailwind lacks.## rtlindocs/jsx-parity.md; CHANGELOG; README; getting-started.An
rtl: trueproject renders both directions: the document'sdirdecides at render time.Not transformed
side/directionprop values (our floating positioning already resolves placement per direction in JS); behaviour JS (carries no classes);input-otpstaysdir="ltr". tw-animate-css's sized logical slides have an upstream bug (Wombosvideo/tw-animate-css#67); gsxui emits none.Verification
go test ./... -count=1including the network e2e tests: green.TestE2ERTLvendors RTL: physical direction classes remain in ~15 components (RTL page says logical) #32's components into a scratch consumer with the flag and asserts the issue's physical classes are gone.ui/*.gsxand all 440registry/generated/*/*.gsxtransform, reparse, are a fixed point, and carry no physical class outside side-keyed arms and variants; a guard test pins that no shipped file uses a construct the walker skips.stylegen --check,--check-authoring,--check-layers,make audit,test-css-audit,test-theme-state,verify-generated,verify-generated-styles,gofmt -l: clean. Playwright 566 passed (one knownhome-showcaseflake, green alone).Spec and plan:
docs/superpowers/specs/2026-09-15-rtl-opt-in-transform-design.md(read both addenda),docs/superpowers/plans/2026-09-16-rtl-opt-in-transform.md.https://claude.ai/code/session_019u7BSQ2Kt9bkwzAXN9hGwv