Skip to content

Remove obsolete Solid Queue tooling - #1509

Merged
skyfallwastaken merged 1 commit into
mainfrom
cleanup/remove-solid-queue-tooling
Aug 3, 2026
Merged

skyfallwastaken merged 1 commit into
mainfrom
cleanup/remove-solid-queue-tooling

Conversation

@skyfallwastaken

@skyfallwastaken skyfallwastaken commented Aug 3, 2026 •

Copy link
Copy Markdown
Member

Summary of the problem

Hackatime uses GoodJob for Active Job and worker execution, but obsolete Solid Queue tooling and configuration remained in the repository from the default Rails template :(

Describe your changes

  • Removed the obsolete bin/jobs Solid Queue binstub.
  • Removed dormant Solid Queue configuration from Puma and the development and production environment configuration.
  • Removed stale commented setup and deployment snippets referencing config/database.yml.sample and cache:warmup.
  • Confirmed with a repository-wide search that no Solid Queue references remain.

Screenshots / Media

N/A

Copilot AI review requested due to automatic review settings August 3, 2026 15:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes leftover Solid Queue tooling/configuration now that Hackatime uses GoodJob for Active Job execution, reducing confusion and eliminating references to unused queue infrastructure.

Changes:

  • Deletes the obsolete bin/jobs Solid Queue binstub.
  • Removes dormant Solid Queue configuration/comments from Puma and Rails environments.
  • Cleans up stale commented setup/deployment snippets referencing nonexistent tasks/files.

Reviewed changes

Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
config/puma.rb Removes the optional Solid Queue Puma plugin hook for single-server deployments.
config/environments/production.rb Deletes commented Solid Queue DB connection config while keeping GoodJob as the adapter.
config/environments/development.rb Deletes commented Solid Queue DB connection config while keeping GoodJob as the adapter.
bin/setup Removes stale commented “copy sample database.yml” snippet.
bin/jobs Removes Solid Queue CLI binstub entirely.
bin/docker-entrypoint Removes stale commented cache warmup snippet referencing a nonexistent task.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@skyfallwastaken
skyfallwastaken merged commit ecb9c1f into main Aug 3, 2026
20 checks passed
@skyfallwastaken
skyfallwastaken deleted the cleanup/remove-solid-queue-tooling branch August 3, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants