Remove obsolete Solid Queue tooling - #1509
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes leftover Solid Queue tooling/configuration now that Hackatime uses GoodJob for Active Job execution, reducing confusion and eliminating references to unused queue infrastructure.
Changes:
- Deletes the obsolete
bin/jobsSolid Queue binstub. - Removes dormant Solid Queue configuration/comments from Puma and Rails environments.
- Cleans up stale commented setup/deployment snippets referencing nonexistent tasks/files.
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| config/puma.rb | Removes the optional Solid Queue Puma plugin hook for single-server deployments. |
| config/environments/production.rb | Deletes commented Solid Queue DB connection config while keeping GoodJob as the adapter. |
| config/environments/development.rb | Deletes commented Solid Queue DB connection config while keeping GoodJob as the adapter. |
| bin/setup | Removes stale commented “copy sample database.yml” snippet. |
| bin/jobs | Removes Solid Queue CLI binstub entirely. |
| bin/docker-entrypoint | Removes stale commented cache warmup snippet referencing a nonexistent task. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the problem
Hackatime uses GoodJob for Active Job and worker execution, but obsolete Solid Queue tooling and configuration remained in the repository from the default Rails template :(
Describe your changes
bin/jobsSolid Queue binstub.config/database.yml.sampleandcache:warmup.Screenshots / Media
N/A