Remove unused backend helpers - #1510
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes backend helper methods/constants that no longer have any callers, reducing navigation noise and keeping the active server implementation surface area clearer.
Changes:
- Removed unused “flavor text” and Inertia/shared-props helpers.
- Simplified service helpers by deleting unused cache/import client methods and an unused heartbeat-counting helper.
- Removed unused dashboard/settings/auth convenience helpers/constants.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/flavor_text.rb | Removes an unused rare_compliment method. |
| app/services/leaderboard_cache.rb | Drops unused timezone key + fetch helpers, leaving only the used read/write/key API. |
| app/services/heartbeat_import_service.rb | Removes an unused count_heartbeats helper (import logic still counts during SAX parsing). |
| app/services/heartbeat_import_dump_client.rb | Removes an unused base_url_for class helper. |
| app/controllers/settings/base_controller.rb | Removes an unused options_props wrapper helper. |
| app/controllers/inertia_controller.rb | Removes an unused currently_hacking_props helper (other callers still invoke the job directly). |
| app/controllers/concerns/dashboard_data.rb | Removes an unused dashboard_filters helper. |
| app/controllers/concerns/auth_helpers.rb | Removes an unused superadmin constant/method, keeping only the used admin helpers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the problem
The backend accumulated isolated helpers and constants that no longer had callers. Keeping these definition-only symbols made the server code harder to navigate and obscured the active implementations.
Describe your changes
Verification included repo-wide direct-reference and dynamic-dispatch searches, a post-rebase symbol scan, and
git diff --check. The fullbin/cisuite could not run locally because the Amp orb does not provide Docker or Ruby; GitHub Actions is expected to provide full-suite coverage for this PR.Screenshots / Media
Not applicable; there are no visual changes.