Simplify setup screen header props

[skyfallwastaken]

Summary of the problem

ScreenHeader required setup callers to provide an emoji that was never rendered. It also accepted raw HTML only to bold one phrase in the terminal guidance.

Describe your changes

Remove the unused emoji prop and its wrapper plumbing. Render terminal guidance through the existing plain subtitle prop, then remove the raw HTML path and dead image comment.

Screenshots / Media

[greptile-apps]

Greptile Summary

This PR simplifies setup-screen headers by removing unused emoji plumbing and the raw-HTML rendering path.

• Removes the obsolete emoji prop from setup components and their callers.
• Replaces terminal guidance HTML with a plain subtitle.
• Removes the dead commented image element from ScreenHeader.

Confidence Score: 5/5

The PR appears safe to merge, with all callers consistently migrated to the simplified header interface.

The removed emoji prop was not rendered, the sole raw-HTML caller now supplies the same guidance as plain text, and no unchanged caller or dependent test retains the old component contract.

Important Files Changed

Filename	Overview
app/javascript/pages/Setup/components/ScreenHeader.svelte	Removes unused emoji support and the raw-HTML branch while retaining title and optional subtitle rendering.
app/javascript/pages/Setup/TerminalCommand.svelte	Migrates terminal guidance from static raw HTML to the plain subtitle prop without dropping its instructional text.
app/javascript/pages/Setup/components/TwoChoiceLayout.svelte	Removes obsolete emoji prop forwarding while preserving the existing header and choice layout.
app/javascript/pages/Setup/LinkScreen.svelte	Removes obsolete emoji prop forwarding while preserving link-screen content.
app/javascript/pages/Setup/Index.svelte	Updates all setup flow callers to match the simplified component interfaces.
app/javascript/pages/Setup/VsCodeSteps.svelte	Updates the header invocation to omit the previously unused emoji prop.

_{Reviews (1): Last reviewed commit: "Simplify setup screen header props" | Re-trigger Greptile}

[Copilot]

Pull request overview

This PR simplifies the Setup flow’s header API by removing unused emoji plumbing and eliminating the html prop path in ScreenHeader, relying on the existing plain subtitle text instead.

Changes:

• Removed the unused emoji prop from ScreenHeader and all Setup callers/wrappers.
• Replaced ScreenHeader’s raw-HTML rendering path (html + {@html ...}) with plain subtitle content for the terminal guidance copy.
• Deleted the now-dead commented-out emoji <img> usage in ScreenHeader.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
app/javascript/pages/Setup/VsCodeSteps.svelte	Drops the removed emoji prop when rendering ScreenHeader.
app/javascript/pages/Setup/TerminalCommand.svelte	Replaces html usage with plain subtitle text and removes emoji prop.
app/javascript/pages/Setup/LinkScreen.svelte	Removes emoji from Props and stops passing it to ScreenHeader.
app/javascript/pages/Setup/Index.svelte	Removes emoji props passed into TwoChoiceLayout and LinkScreen.
app/javascript/pages/Setup/components/TwoChoiceLayout.svelte	Removes emoji from Props and stops passing it to ScreenHeader.
app/javascript/pages/Setup/components/ScreenHeader.svelte	Removes emoji and html props and the raw-HTML rendering branch, leaving title + optional subtitle.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.