Use GetPartialObject() in classic mode when possible - #124
Open
mcuelenaere wants to merge 2 commits into
Open
mcuelenaere wants to merge 2 commits into
mcuelenaere wants to merge 2 commits into
Conversation
…ANDROID_GET_PARTIAL_OBJECT64
…eed to fetch the whole file on a temporary backing storage
Owner
|
code looks roughly OK. Can you confirm that this case has test coverage? Did you fill in the Google CLA? (https://cla.developers.google.com/about/google-individual) |
Author
|
@hanwen what do you mean by test "coverage"? Whether it is handled by I have signed the Google CLA for a different project already, so yes. |
Owner
|
yes, if you insert a panic into your changed code, does device_test generate a panic? If yes, then it's OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Android devices do not seem to implement the Android MTP extensions, yet still support GetPartialObject. Use it when the file size is less than MaxUint32 and when there aren't any pending writes to file being read.
NOTE: this works for me, though I am still hitting the
fatal error got type 0 (CONTAINER_UNDEFINED) in response, want CONTAINER_RESPONSE.; closing connectionbug from time to time; which I'm taking is unrelated to this change (as this is a high-level change and that bug is more lower-level related)