Handle UTF-16 surrogate pairs in encoding - #168
Open
Neighbor-Z wants to merge 1 commit into
Open
Neighbor-Z wants to merge 1 commit into
Neighbor-Z wants to merge 1 commit into
Conversation
Add proper handling of UTF-16 surrogate pairs in mtp/encoding.go. decodeStr now recognizes high/low surrogates and combines them into runes (avoids producing broken emoji and other >U+FFFF chars) and guards against trimming when no bytes were written. encodeStr encodes runes above the BMP as UTF-16 surrogate pairs and correctly counts code units. encodeStrField allocates a larger buffer to accommodate worst-case surrogate expansion. These changes fix incorrect encoding/decoding of characters outside the BMP issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add proper handling of UTF-16 surrogate pairs in mtp/encoding.go. decodeStr now recognizes high/low surrogates and combines them into runes (avoids producing broken emoji and other >U+FFFF chars) and guards against trimming when no bytes were written. encodeStr encodes runes above the BMP as UTF-16 surrogate pairs and correctly counts code units. encodeStrField allocates a larger buffer to accommodate worst-case surrogate expansion. These changes fix incorrect encoding/decoding of characters outside the BMP issue.