fix(starpuff): 收斂 Codex review 教學與治理缺口 - #1047
Merged
Merged
Conversation
added 7 commits
August 26, 2026 13:43
- Shelly 首次進入 spin 時送出實際教學事件 - 補回歸測試鎖定事件與狀態轉換 測試：pnpm --filter @app/starpuff exec vitest run src/game/systems/enemies.test.ts
- 教學只接受 Shelly 進入 spin 的實際事件 - 移除可能誤完成 lesson 的玩家護盾事件監聽 測試：starpuff guidance/enemies targeted Vitest
- 訂閱設定變更並即時隱藏或恢復目前提示 - 補測試鎖定同一場景的開關行為 測試：starpuff guidanceDirector targeted Vitest
- 自動事故 issue 補上 bug 類型與正式追蹤段落 - 以 source-level test 鎖定 issue 欄位與驗收契約 測試：ratewise build-scripts targeted Vitest
- 直接驗證第三條 override 從 >=3.0.0 起算 - 防止只驗到 5.x 而漏掉 3.x／4.x 依賴 測試：pnpm --filter @app/ratewise exec vitest run src/config/__tests__/build-scripts.test.ts
- 將排程中斷的 issue 標籤與正式 body 契約寫入 AGENTS - 保留查詢失敗時的 fail-safe 與恢復關閉語意 測試：node scripts/verify-002-log.mjs
- 新增 StarPuff follow-up patch changeset - 集中記錄本 PR 五項修正與一項已驗證的 neutral 意見 測試：node scripts/verify-002-log.mjs
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
|
✅ SEO 審計通過！所有 2026 標準驗證項目都符合要求。
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e2833cc768
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- 讓 follow-up changeset 同時涵蓋 RateWise 與 StarPuff package - 將 MoneyBox issue 標籤與五段 body 契約同步至 CLAUDE.md 測試：pnpm changeset status；node scripts/verify-002-log.mjs；StarPuff 3 files/11 tests；RateWise 49 tests
Contributor
|
✅ SEO 審計通過！所有 2026 標準驗證項目都符合要求。
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
這是已合併 PR #1045 的 follow-up，收斂合併後新增的 Codex review 意見，並將歷史 PR #1039、#1031 的治理缺口補回可驗證的程式與文件。
變更
bug標籤與摘要、背景／證據、影響、範圍、驗收標準。>=3.0.0覆蓋。驗證
build:ratewise通過。關聯