Skip to content

Rodolfo/new dto validator - #26

Open
Rodolfodc wants to merge 5 commits into
developmentfrom
rodolfo/new_dto_validator
Open

Rodolfo/new dto validator#26
Rodolfodc wants to merge 5 commits into
developmentfrom
rodolfo/new_dto_validator

Conversation

@Rodolfodc

Copy link
Copy Markdown
Contributor

This PR:

  • Improve DTO mechanism using marshmallow API and ensures a the correct data structure for it.
  • Add the capacity for the server log to be registered in file system.

@matheusmota

Copy link
Copy Markdown
Member

Looks good, @Rodolfodc
Is it fully functional? I could not reproduce it. Is the dto.py concluded? If not, maybe we should conclude it and perform some tests. I have never used Marshmallow before; maybe we could discuss it
What do you think?
Cheers

@Rodolfodc

Copy link
Copy Markdown
Contributor Author

Hi @matheusmota, yes, it was supposed to be really functional actually! maybe there's any detail that I'm missing! Yes I think it would be really good if we discussed it and we could talk about any other issues, just let me know when you are able.

@Rodolfodc

Copy link
Copy Markdown
Contributor Author

Maybe the implementation could be improved with some value validations, and I found out now, I should improve the code to send to Kafka non-expected DTOs when marshmallow conversion functions throws exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants