Support hexadecimal OpenType language and script overrides - #476
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hexadecimal private-use tags such as
x-hbot-4d4f4e54were ignored, so theMONTlanguage system used in Myanmar shaping tests was not selected. Decode the first eight hexadecimal digits afterhbot-orhbsc-as an OpenType language or script tag, matching HarfBuzz.Add regression coverage for
MONT, script overrides, byte and case preservation, default tags, malformed input, trailing digits, and override precedence, plus a changelog entry. All 36 new cases were checked against a locally built HarfBuzz library.Validation passed:
cargo test --workspacecargo test --workspace --features icucargo build -p harfrust --no-default-features --features libmcargo fmt --all -- --checkcargo clippy --all-features --all-targets -- -D warnings