Skip to content

fix(review): file path overflow, copyable paths, legend layout, accumulated diffs - #178

Merged
jeonghun-jj-lee merged 1 commit into
local/amicodefrom
jj/174-session-scoped-files-changed
Aug 10, 2026
Merged

fix(review): file path overflow, copyable paths, legend layout, accumulated diffs#178
jeonghun-jj-lee merged 1 commit into
local/amicodefrom
jj/174-session-scoped-files-changed

Conversation

@jeonghun-jj-lee

Copy link
Copy Markdown
Contributor

Summary

Fixes several bugs in the review panel:

File path overflow

  • File path truncates with ellipsis instead of bleeding over the panel edge
  • Tooltip on hover shows the full path

Copyable file paths

  • Right-click context menu: Copy full path / Copy filename
  • All paths displayed as ~/‑relative

Context tree legend layout

  • Legend on its own row (never overflows), recenter button beside it
  • Panel column min-width (WORK_COLUMN_WIDTH_MIN = 330) fits legend + button

Accumulated diffs (TDD)

  • Bug: Map.set overwrote previous edits — only the last edit rendered per file
  • Fix: accumulateDiffs() keeps last patch, sums counts; server refetches on idle

…ulated diffs

- CSS: file-path truncates with ellipsis instead of bleeding over edge
- CSS: removed hardcoded min-width; panel column min driven by
  WORK_COLUMN_WIDTH_MIN (280px — fits the context tree legend row)
- UI: filepath shows full path on hover, right-click to copy full path
- Layout: context tree legend on its own row with recenter button;
  title row is just title + count (never overflows)
- Logic: multi-edit files keep the last edit's patch for immediate display
  and sum additions/deletions; server refetches when session goes idle
  (status running→idle changes the query key) and replaces the fallback
  with the correct git-based cumulative diff + accurate line counts
- Server: session.ts fallback 2 uses same accumulation pattern
@jeonghun-jj-lee
jeonghun-jj-lee merged commit 3309fb6 into local/amicode Aug 10, 2026
1 of 4 checks passed
@jeonghun-jj-lee
jeonghun-jj-lee deleted the jj/174-session-scoped-files-changed branch August 10, 2026 23:47
@jeonghun-jj-lee
jeonghun-jj-lee restored the jj/174-session-scoped-files-changed branch August 10, 2026 23:49
@jeonghun-jj-lee
jeonghun-jj-lee deleted the jj/174-session-scoped-files-changed branch August 10, 2026 23:52
@jeonghun-jj-lee
jeonghun-jj-lee restored the jj/174-session-scoped-files-changed branch August 10, 2026 23:53
@jeonghun-jj-lee
jeonghun-jj-lee deleted the jj/174-session-scoped-files-changed branch August 10, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant