feat(app): add "Delete permanently" hover action on archived sessions - #180
Merged
Merged
Conversation
… (#310) Add a trash-icon hover button next to the existing Unarchive button on archived session rows in both the home dashboard flyout and the in-session header dropdown. Clicking it opens a confirmation dialog (reusing the existing i18n keys and DialogV2 pattern) before permanently deleting the session via the SDK. Closes #310
- Switch delete button from IconV2 (which lacks a 'trash' entry and silently falls back to '+') to the v1 Icon component which has the proper trash SVG. - Bump TooltipV2 z-index from 1000 to 10000 so tooltips render above the sessions flyout (z-index 9999). This fixes the hover bubble appearing behind the titlebar dropdown for all tooltip actions (unarchive, delete).
The useDialog context computed z-index as 50 + layer*10, rendering the dialog overlay and container behind the titlebar sessions flyout (z-index 9999). Bump the base to 10000 so confirmation dialogs appear on top. The inline style from dialog.tsx overrides the CSS fallback in dialog-v2.css, so the CSS values (z-index: 50) are left as-is — they only matter for non-portalled dialogs.
The outside-click handlers on both the titlebar and dashboard sessions flyouts were closing the dropdown when the user clicked inside the delete confirmation dialog (portalled to body, outside flyoutRoot). Add a check to skip dismissal when the click target is inside a dialog layer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a trash-icon hover button next to the existing Unarchive button on archived session rows in both the home dashboard flyout and the in-session header dropdown. Clicking it opens a confirmation dialog before permanently deleting the session.
Also fixes:
Closes harmoniqs/amicode#310