fix(server): allow file read/write for absolute paths outside workspace - #186
Merged
Merged
Conversation
The Preview tab's raw editor needs to read and save files that live outside the project directory (e.g. files in ~/.julia/dev/Altissimo that the session edited). The traversal guard now only blocks relative-path escapes; absolute paths are served directly from disk via fs/promises.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Preview tab needs to read and save files that live outside the project directory (e.g. files in
~/.julia/dev/Altissimothat the session edited). The traversal guard now only blocks relative-path escapes; absolute paths are served directly from disk viafs/promises.Without this,
sdk().client.file.read({ path })fails with "Path escapes the location" for any absolute path outside the workspace root — meaning the Preview tab can't render files it touched in other directories.