Implement autorization with new APIv2 token - #14
Open
MelvinFrederiks wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as i could tell is was not possible to authenticate with a new fine-grained apiv2 token in this API implementation. I've added basic support for this, so now you don't need to pass or store a password anymore if you are using this API.
If the config file contains both an api token and a username&password, opt for the api token.
Tested with_token with the following snippet:
Tested config file in the same way:
This implementation does not validate the token upon creation of the HashtopolisConfig object, so an incorrect token will not raise an error until the first actual API call is made. However this currently also happens when authenticating with a password.