Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new API field is modeled as required in generated schemas/types despite a stated backend dependency, and the new lock-icon behavior lacks corresponding unit test coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds UI support for indicating when a task’s hashlist is marked as secret by plumbing a new hashlistIsSecret field from the API into the task wrapper model and rendering a lock icon in the Tasks table.
Changes:
- Extend generated API Zod schemas and TypeScript types to include
hashlistIsSecret. - Extend the internal task wrapper display model to expose
hashlistIsSecret. - Render a lock icon (with tooltip) in the Tasks table when
hashlistIsSecretis true.
File summaries
| File | Description |
|---|---|
| src/generated/api/zod/task-wrapper.ts | Adds hashlistIsSecret to Zod response schemas for task wrapper display endpoints. |
| src/generated/api/types/task-wrapper.ts | Adds hashlistIsSecret to generated TypeScript response types. |
| src/app/core/_models/task.model.ts | Adds hashlistIsSecret to the app’s task wrapper display model interface. |
| src/app/core/_components/tables/tasks-table/tasks-table.component.ts | Shows a lock icon in the HASHLISTS column when the hashlist is secret. |
Review details
- Files reviewed: 2/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Can you update the branch with the new changes on master where we can create .backend-ref to test against the correct openapi.json in the backend branch? |
Not sure what i should do, running "npm run generate:api" does not seem to add the issecret field, is there something i should do that it can generate the fields properly? |
Download the openapi.json generated from the backend which should work with this frontend branch and place it in this repo. And then adjust (or create) the file .backend-ref containing the commit hash of the newest commit in your master PR connected to this one. (There is information about this idea here: https://github.com/hashtopolis/web-ui/blob/master/DEVELOPMENT.md#api-contract-sync) |
Make it more clear to an user when a hashlist is secret. hashtopolis/server#2480 should be merged first