Skip to content

[Dependency] Require plotext version >= 6.0.0 - #163

Merged
pnizenkov merged 2 commits into
mainfrom
fix.plotext.version
Aug 25, 2026
Merged

[Dependency] Require plotext version >= 6.0.0#163
pnizenkov merged 2 commits into
mainfrom
fix.plotext.version

Conversation

@pnizenkov

Copy link
Copy Markdown
Contributor

Set required plotext version to 5.3.2 due to removed simple_bar function in 6.0.0 (https://plotext.readthedocs.io/en/latest/changelog.html#plot-creation)

This currently breaks PICLas' pipelines

@pnizenkov
pnizenkov requested a review from kopperp August 25, 2026 11:35
@kopperp kopperp self-assigned this Aug 25, 2026
@kopperp kopperp added the bug Something isn't working label Aug 25, 2026
@kopperp kopperp added this to the v1.1.0 milestone Aug 25, 2026

@kopperp kopperp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do agree that this would work short-term. However, I would much prefer migrating simple_bar to bar following the documentation.

@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown

☂️ Code Coverage

current status: ✅

Overall Coverage

Statements Covered Coverage Threshold Status
3223 2940 91% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
pyhope/basis/basis_jacobian.py 88% 🟢
TOTAL 88% 🟢

updated for commit: 9e07611 by action🐍

@kopperp kopperp changed the title Fix: set required plotext version to 5.3.2 [Dependency] Require plotext version >= 6.0.0 Aug 25, 2026

@kopperp kopperp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, approved

@pnizenkov
pnizenkov merged commit f963733 into main Aug 25, 2026
16 checks passed
@pnizenkov
pnizenkov deleted the fix.plotext.version branch August 25, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants