fix: stop aiming the release at npmjs - #27
Merged
Conversation
Releases fail preflight with "npm: NPM_TOKEN not set", which reads like a missing secret and is actually a false destination. The language detection that makes hyperi-ci run the TypeScript quality handler here -- package.json, which exists only to carry the semantic-release scripts -- also points publish at npmjs. Opting out rather than supplying a token. This repo has no publish target at all: v2.24.4 shipped zero assets, and install.sh is run from a clone rather than fetched from a registry, so a release is a tag, a CHANGELOG commit and a GitHub Release. Supplying NPM_TOKEN would put an Ansible installer on a public package registry. `publish` stays enabled, because that is what tags and cuts the release.
Contributor
|
Released in v2.24.5 — https://github.com/hyperi-io/hyperi-developer/releases/tag/v2.24.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releasing this repo fails at preflight:
That reads like a missing secret. It is not - it is a destination this repo
should never have had. The same language detection that makes hyperi-ci run the
TypeScript quality handler here (package.json, which exists only to carry the
semantic-release scripts) also aims publish at npmjs.
We are opting out rather than supplying a token, because this repo has no
publish target at all:
v2.24.4 shipped nothing, anywhere. install.sh is run from a clone, not fetched
from a registry, so a release here is a tag, a CHANGELOG commit and a GitHub
Release. Supplying NPM_TOKEN would put an Ansible installer on a public package
registry.
publishstays enabled, because that is what tags and cuts the release.Done when:
hyperi-ci publishgets past preflight and moves the tag.Verified: the merged config now reports
"npm": false(
hyperi-ci config --json). The failing run ishttps://github.com/hyperi-io/hyperi-developer/actions/runs/30785807629 - it
died in Plan, so nothing was tagged or published and there is nothing to
unwind.