fix(ci): accept from-head and bump on dispatch, like the rest of the fleet - #13
Merged
Conversation
…fleet `hyperi-ci publish` sends tag, from-head and bump. This caller did not declare all three, so a release from HEAD failed with HTTP 422 before the plan job started. workflow_dispatch.inputs only work when declared in the workflow that RECEIVES the event, so the reusable workflow cannot supply them - every caller declares and forwards them itself, and drifts on its own. Found by `hyperi-ci audit-callers`, which reports this against the dispatch contract rather than waiting for the next release to fail (hyperi-ci#88).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hyperi-ci publishsendstag,from-headandbump. This caller declared onlytag, and declared itrequired: true- so a release from HEAD 422'd before the plan job started, and even a tag dispatch was the only path available.workflow_dispatch.inputsonly work when declared in the workflow that RECEIVES the event, so the reusable workflow cannot supply them. Every caller declares and forwards them itself, and drifts on its own.Found by
hyperi-ci audit-callers(hyperi-io/hyperi-ci#88), which reports drift against the dispatch contract instead of waiting for the next release to fail. This repo was never in the manual audit that issue started from.Verified:
hyperi-ci audit-callers --project-dir .is clean on this branch.Done when a release from HEAD dispatches instead of 422ing.