[dependencies] Remove unmaintained dependency "zap-logfmt"

[liran-funaro]

The package github.com/sykesm/zap-logfmt is no longer maintained (last commit was 5 years ago).
This commit removes this dependency.

• resolves Remove dependency on github.com/sykesm/zap-logfmt #53

[liran-funaro]

Pass all Fabric unit tests: https://github.com/liran-funaro/fabric/actions/runs/28320919435

[liran-funaro]

@pfi79 , friendly ping on this whenever you get a chance to review. Thanks!

[pfi79]

I'll try to criticize your PR.:

1. here is the commit that added logfmt. It seems to me that you have deleted more code than necessary in your change.
2. I still don't like that with the removal of the library dependency, you also removed the logfmt setting. Try to keep logfmt, but remove the dependency on the library.

[liran-funaro]

@pfi79 Thanks for the review.

1. Code removal: The original zap-logfmt package consisted of just a single file. Because it has since expanded, more files needed to be cleaned up here. I only removed code introduced by that specific commit, while adding necessary logic to preserve the exact original behavior.
2. logfmt option: As noted in Remove dependency on github.com/sykesm/zap-logfmt #53, the logfmt option isn't officially documented, and I'm not aware of any active production use. Supporting it would require extra boilerplate that we'd have to maintain solely for this edge case.

Let me know how you'd like to proceed!

[pfi79]

Why did you delete these settings? they were before the addition of the zap-logfmt dependency.

[liran-funaro]

They are hard-coded in the new implementation. This is because we only have one use case for this module.
The original one was an external lib; thus, it had to be generic.

[pfi79]

2. logfmt option: As noted in Remove dependency on github.com/sykesm/zap-logfmt #53, the logfmt option isn't officially documented, and I'm not aware of any active production use. Supporting it would require extra boilerplate that we'd have to maintain solely for this edge case.

To make decisions on your change, I want to figure out how logfmt differs from the rest of the console and json.
Not in theory, but in fact. Where are the differences?

[liran-funaro]

To make decisions on your change, I want to figure out how logfmt differs from the rest of the console and json.
Not in theory, but in fact. Where are the differences?

logfmt is similar to JSON, but the fields are presented in the logfmt format instead of JSON
For example:

ts=<epoch>  level=<lower>  name=<logger, only if LoggerName!="">  caller=<short, only if Caller.Defined>  msg="..."   [With-ctx fields]  [entry fields]  stacktrace=<..., only if ent.Stack!="", appended LAST after fields>

[pfi79]

To make decisions on your change, I want to figure out how logfmt differs from the rest of the console and json.
Not in theory, but in fact. Where are the differences?

logfmt is similar to JSON, but the fields are presented in the logfmt format instead of JSON For example:

ts=<epoch>  level=<lower>  name=<logger, only if LoggerName!="">  caller=<short, only if Caller.Defined>  msg="..."   [With-ctx fields]  [entry fields]  stacktrace=<..., only if ent.Stack!="", appended LAST after fields>

I'm sorry, but I don't understand.
Can you use an example, a specific example, to give an output in all 3 variants?
Please understand that it is not as clear to me as it is to you why we can get rid of LOGFMT.

[liran-funaro]

@pfi79

CONSOLE  2021-03-23 22:15:21.969 UTC [orderer.consensus.etcdraft] becomePreCandidate -> INFO 001 2 became pre-candidate at term 1 channel=canalenergia node=2
JSON     {"level":"info","ts":1616537721.9689999,"name":"orderer.consensus.etcdraft","caller":"raft/raft.go:707","msg":"2 became pre-candidate at term 1","channel":"canalenergia","node":2}
LOGFMT   ts=1616537721.9689999 level=info name=orderer.consensus.etcdraft caller=raft/raft.go:707 msg="2 became pre-candidate at term 1" channel=canalenergia node=2

[liran-funaro]

@pfi79 Is there any additional action item for me regarding this PR?

[pfi79]

Thank you for your hard work.