Preserve repository-root path whitespace - #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
String.trim()togit rev-parse --show-topleveloutputrepositoryandrepositoryso the old implementation demonstrably resolves to the wrong pathdistand document the fixWhy
findRepository()currently runs Git from the correct candidate repository and then callsresult.stdout.trim()before resolving the reported top-level path. A repository directory may legally end in whitespace on POSIX. Ifrepositoryand siblingrepositoryboth exist, trimming the Git output silently changes path identity and can make ProofDiff return the sibling directory instead of the repository Git actually identified.The fix strips only the output record's final newline (
CRLFon Windows,LFelsewhere) and leaves all path characters untouched.Verification
npm testpassed after the changenpm run clean && npm run buildpassedgit diff --checkpasseddist/git.*refreshed