Fix split() to dispatch to base::split() for non-data-frame input - #125
Merged
Merged
Conversation
split() unconditionally treated its first argument as a table, so attaching basetable broke the base R idiom split(vector, factor) for any non-data-frame input -- including inside R Markdown/Quarto's own rendering pipeline, which calls split() unqualified internally and would error with "cols must not be NULL" as soon as basetable was attached, regardless of what else the document did. split() now checks is.data.frame() and dispatches to base::split() when the input is not a table, matching base R's behavior for vectors while leaving the existing table-splitting behavior unchanged. Bumps to 1.4.2 and updates cran-comments.md for resubmission.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan