Skip to content

update: helium 0.16.1.1 - #372

Merged
dumbmoron merged 3 commits into
mainfrom
update
Aug 28, 2026
Merged

update: helium 0.16.1.1#372
dumbmoron merged 3 commits into
mainfrom
update

Conversation

@helium-bot

Copy link
Copy Markdown
Collaborator

No description provided.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Changes

The release updates Helium Chromium to version 0.16.1.1. It adds build support for clang-format and ARM64. Linux branding, executable names, default-browser handling, middle-click paste controls, and tab-stroke behavior are updated.

Helium Linux update

Layer / File(s) Summary
Release inputs and metadata
helium-chromium, package/helium-bin.spec, package/net.imput.helium.metainfo.xml
The Chromium submodule and package metadata move to Helium version 0.16.1.1.
Build and cross-compilation support
docker/build.Dockerfile, scripts/shared.sh, patches/ungoogled-chromium/portablelinux/drop-nodejs-version-check.patch, patches/ungoogled-chromium/portablelinux/fix-compiling-on-arm64.patch
The build installs and provisions clang-format, removes Node.js version checks, and selects ARM64-specific host, sysroot, Rust, LLVM, and compiler settings.
Linux identity and packaging
patches/helium/linux/change-chromium-branding.patch, patches/helium/linux/rename-chrome-binary.patch
Linux package metadata, data directories, desktop integration, audio identification, icons, binaries, Crashpad handling, symbols, stripping, and packaged executables use Helium names.
Missing desktop-file handling
patches/helium/linux/add-error-for-missing-desktop-file.patch
Linux reports CANNOT_BE_DEFAULT when no browser desktop file exists and updates default-browser UI and URL handling for that state.
Middle-click paste override
patches/helium/linux/add-middle-click-paste-flag.patch
A Linux-only Helium flag controls middle-click paste. Explicit feature overrides take precedence over the system Linux UI setting.
Linux tab-stroke behavior
patches/helium/linux/disable-tab-strokes.patch
Linux disables tab strokes through the ChromeOS behavior path.

Merge Risk: 🟠 High · up to 60122

This update omits the chrome_sandbox helper from Linux packages, which can prevent the application from starting safely on systems without unprivileged user namespaces; merge should be blocked until the helper or an equivalent tested sandbox is included. Minor packaging-message and branding inconsistencies also remain.

🚥 Pre-merge checks | ✅ 2 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title identifies the version update and is within the 72-character limit. However, update is a generic scope and does not follow the repository's scope-first style requirements. ([github.com](ht… Use a specific scope that describes the changed area, such as release: update Helium to 0.16.1.1, while keeping the title within 65 characters before the merge reference.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (11 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title identifies the version update and is within the 72-character limit. However, update is a generic scope and does not follow the repository's scope-first style requirements. (github.com)

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (11 skipped: 11 unsupported.)


Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Aug 27, 2026

Copy link
Copy Markdown

Reviews (1): Last reviewed commit: "update: helium 0.16.1.1" | Re-trigger Greptile

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (3)
patches/helium/linux/add-error-for-missing-desktop-file.patch (1)

107-109: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Keep the error text aligned with the searched paths.

When XDG_DATA_HOME or XDG_DATA_DIRS is set, HasInstalledDesktopFile() searches the directories returned by base::nix::GetXDGDataSearchLocations(env), but GetDefaultBrowserError() displays only the default directories. The message can therefore list directories that were not searched and omit directories that were searched. Use the computed directory list or remove the hard-coded list.

Source: MCP tools

patches/helium/linux/change-chromium-branding.patch (1)

92-93: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Update the remaining Chromium package descriptions.

MENUNAME now says Helium, but SHORTDESC and FULLDESC still identify the product as Chromium. Package metadata generated from this file will show mixed branding. Update both descriptions to Helium.

patches/helium/linux/rename-chrome-binary.patch (1)

78-80: 🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

Package chrome_sandbox in every Linux artifact.

The patch removes it from packaging_files_executables, and scripts/package.sh omits it from the tarball file list. The AppImage copies that tarball, so both artifacts lack Chromium’s setuid Layer-1 fallback when unprivileged user namespaces are disabled. Restore the helper and preserve its required setuid-root permissions, or provide and test an equivalent sandbox.


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ac99fd48-5ec5-44f7-8e14-6a725473983f

📥 Commits

Reviewing files that changed from the base of the PR and between 405d7d3 and 6012297.

📒 Files selected for processing (12)
  • docker/build.Dockerfile
  • helium-chromium
  • package/helium-bin.spec
  • package/net.imput.helium.metainfo.xml
  • patches/helium/linux/add-error-for-missing-desktop-file.patch
  • patches/helium/linux/add-middle-click-paste-flag.patch
  • patches/helium/linux/change-chromium-branding.patch
  • patches/helium/linux/disable-tab-strokes.patch
  • patches/helium/linux/rename-chrome-binary.patch
  • patches/ungoogled-chromium/portablelinux/drop-nodejs-version-check.patch
  • patches/ungoogled-chromium/portablelinux/fix-compiling-on-arm64.patch
  • scripts/shared.sh

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@dumbmoron
dumbmoron merged commit 31ffef3 into main Aug 28, 2026
5 checks passed
@dumbmoron
dumbmoron deleted the update branch August 28, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants