feat: add a test case for the function props not recalculating - #39
Open
OliverGeneser wants to merge 2 commits into
Open
feat: add a test case for the function props not recalculating#39OliverGeneser wants to merge 2 commits into
OliverGeneser wants to merge 2 commits into
Conversation
palkerecsenyi
force-pushed
the
fix-prop-recalc
branch
from
September 3, 2026 12:14
a9a8ae2 to
399e567
Compare
palkerecsenyi
force-pushed
the
fix-prop-recalc
branch
from
September 3, 2026 12:16
399e567 to
6122d23
Compare
Contributor
|
I've added a fix for the bug and the tests are passing now. This code meant that export function parametrize(Component, extraProps) {
const ParametrizedComponent = props => {
// handle deferred prop calculation
if (typeof extraProps === 'function') {
extraProps = extraProps(props);
} |
OliverGeneser
marked this pull request as ready for review
September 3, 2026 12:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.