Improve types around potentials in ExpansionWranglerInterface - #126
Open
alexfikl wants to merge 3 commits into
Open
Improve types around potentials in ExpansionWranglerInterface#126alexfikl wants to merge 3 commits into
alexfikl wants to merge 3 commits into
Conversation
alexfikl
commented
Aug 20, 2026
Comment on lines
-758
to
+763
| def reorder_potentials(self, potentials: Array) -> Array: | ||
| return potentials[self.tree.sorted_target_ids] | ||
| def reorder_potentials(self, potentials: PotentialArray) -> PotentialArray: | ||
| def reorder(x: Array) -> Array: | ||
| return x[self.tree.sorted_target_ids] | ||
|
|
||
| return obj_array.vectorize(reorder, potentials) |
Contributor
Author
There was a problem hiding this comment.
Is this tested anywhere? It seems like it would break when the result is an object array.
| def real(x: Array) -> Array: | ||
| return x.real | ||
|
|
||
| potentials = obj_array.vectorize(real, potentials) |
Contributor
Author
There was a problem hiding this comment.
obj_array_real isn't typed 😢
Comment on lines
+122
to
+123
| rng: np.random.Generator | None = None, | ||
| seed: int | None = 15) -> obj_array.ObjectArray1D[Array]: |
Contributor
Author
There was a problem hiding this comment.
Added the rng as an argument here too, since that's the way numpy does it these days.
Contributor
Author
|
For what it's worth, this passes on Sphinx 9.1.0: https://github.com/inducer/boxtree/actions/runs/32374671129/job/96443075259?pr=126. |
alexfikl
marked this pull request as ready for review
August 20, 2026 13:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a little
PotentialArray = Array | ObjectArray[Array]alias and uses it in all the functions working with potentials:reorder_potentials,eval_multipoles, etc.I tried doing some sort of
PotentialArrayT = TypeVar(..., bound=CanAdd), but e.g. the pyfmmlib wrangler decides at runtime if the potential is an array or an object array, so that doesn't work.xref: inducer/sumpy#300