Skip to content

Fix type checks in parse_domains #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inducer merged 1 commit into from
Aug 18, 2026
Merged

Fix type checks in parse_domains #1038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions loopy/kernel/creation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,7 +1069,7 @@ def parse_domains(
result: list[nisl.Set] = []
used_inames: set[InameStr] = set()

for dom in domains:
for i, dom in enumerate(domains):
if isinstance(dom, str):
if not dom.lstrip().startswith("["):
# i.e. if no parameters are already given
Expand All @@ -1079,17 +1079,18 @@ def parse_domains(
dom = "[{}] -> {}".format(",".join(sorted(parameters)), dom)

try:
dom = isl.BasicSet.read_from_str(isl.DEFAULT_CONTEXT, dom)
dom = nisl.make_set(dom)
except Exception:
print("failed to parse domain '%s'" % dom)
raise
else:
assert isinstance(dom, (isl.Set, isl.BasicSet))
# assert dom.get_ctx() == ctx

dom = nisl.to_named(dom)
if isinstance(dom, nisl.BasicSet):
elif isinstance(dom, isl.Set):
dom = nisl.to_named(dom)
elif isinstance(dom, isl.BasicSet):
dom = nisl.to_named(dom).as_set()
elif isinstance(dom, nisl.BasicSet):
dom = dom.as_set()
else:
raise TypeError(f"unexpected type of domain {i+1} (1-based)")

for iname in dom.space.set_names:
if iname in used_inames:
Expand Down
Loading