Build Windows release binaries via CMAKE_POLICY_VERSION_MINIMUM - #1
Closed
Ramius1701 wants to merge 1 commit into
Closed
Ramius1701 wants to merge 1 commit into
Ramius1701 wants to merge 1 commit into
Conversation
The opus crate vendors libopus and builds it with cmake. libopus's CMakeLists.txt still declares cmake_minimum_required(VERSION 3.1), which CMake 4 (what windows-latest ships) refuses outright. Setting CMAKE_POLICY_VERSION_MINIMUM=3.5 is CMake's own documented escape hatch for exactly this, and a cmake new enough to need the env var also recognizes current Visual Studio versions as a generator — so it turns out to fix both halves of the problem the removed comment described, not just the CMake-4 half. Verified locally: cargo build --release, cargo test (31/31), and the two_clients end-to-end example (real SDP offer/answer, real Opus encode/decode, real per-listener mixing) all pass on Windows with this one env var set and nothing else changed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Ramius1701
added a commit
to Ramius1701/OpenSim-Confluence
that referenced
this pull request
Sep 13, 2026
Points the already-built os-webrtc-janus addon at ConfluenceVoice (WebRtcVoiceServiceConnector) instead of a Janus gateway, via a new bin/config/os-webrtc-janus.ini. Verified with a real region boot: the addon loads the config and enables WebRtcVoiceServiceConnector for both spatial and non-spatial voice. ROADMAP.md: moves wolfvoice out of "Explicitly out of scope" (excluded 2026-09-09, no reason recorded) into "In progress" now that the operator has explicitly asked to resume, with today's work recorded. PROJECT_LOG.md: full account of the wolfvoice Windows CI fix (CMAKE_POLICY_VERSION_MINIMUM=3.5, submitted upstream as intelligentwolf/wolfvoice#1), the new independent ConfluenceVoice project, and the wiring/verification steps above. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Author
|
Closing this: the downstream project is using wolfvoice as a read-only donor and won't be maintaining a fork. The CMAKE_POLICY_VERSION_MINIMUM=3.5 note in the diff still fixes the Windows build if it's useful to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CMAKE_POLICY_VERSION_MINIMUM=3.5for thecargo buildstep.windows-latest/x86_64-pc-windows-msvcentry to the release matrix.Why this works
The
opuscrate vendors libopus and builds it viacmake. libopus'sCMakeLists.txtstill declarescmake_minimum_required(VERSION 3.1), which CMake 4 (whatwindows-latestships) refuses outright: "Compatibility with CMake < 3.5 has been removed from CMake."CMAKE_POLICY_VERSION_MINIMUMis CMake's own documented escape hatch for exactly this situation — it configures the project as if it had declared at least that policy version, rather than hard-erroring. The removed comment framed this as two separate failures (the CMake-4 rejection, and CMake 3.31 not recognizing the current Visual Studio generator name) needing two separate fixes. It turns out acmakenew enough to accept the env var is also new enough to recognize current Visual Studio versions, so this one change resolves both.Test plan
Verified locally on Windows (Rust 1.98.1, CMake 4.4.3, VS 2026 Community's MSVC toolset):
cargo build --releasesucceeds with onlyCMAKE_POLICY_VERSION_MINIMUM=3.5setcargo test --release— 31/31 passcargo run --release --example two_clients— real SDP offer/answer, real Opus encode/decode, real per-listener mixing all pass (PASS,AUDIO_MIXED=true ROSTER_DELIVERED=true LEAVE_NOTIFIED=true)macOS is left alone — the same fix likely applies there too, but I have no Mac to verify it on, so I didn't touch that part of the matrix.
🤖 Generated with Claude Code