Conversation
the-glu
changed the title
the-glu
force-pushed
the
memstore_scd_cleanup_legacy
branch
from
June 17, 2026 08:38
17063bf to
21ec707
Compare
barroco
added
the
dss-raft
the-glu
force-pushed
the
memstore_scd_cleanup_legacy
branch
from
June 22, 2026 12:26
21ec707 to
f2aa4d9
Compare
the-glu
force-pushed
the
memstore_scd_cleanup_legacy
branch
from
June 22, 2026 12:36
f2aa4d9 to
b32cb65
Compare
mickmis
approved these changes
Sep 2, 2026
mickmis
left a comment
mickmis
left a comment
Contributor
There was a problem hiding this comment.
LGTM modulo minor comments
| func cloneTime(t *time.Time) *time.Time { | ||
| if t == nil { | ||
| return nil | ||
| func timePtr(t time.Time) *time.Time { |
| return nil | ||
| } | ||
|
|
||
| func float32Ptr(f float32) *float32 { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows #1538
It removes some legacy in SCD coming from sqlstore. Since Constraints/OperationalIntents/Subscriptions cannot have nil start/end time, this removes this possibility in the memstore layer. The same is done for AltitudeLower/Upper in OperationalIntents.
Tests have been adapted as well.
Contributes to #1492