fix: satisfy eslint for PointCloud refs and type assertions#26
Merged
Conversation
Move camera/controls/invalidate ref sync into an effect, and drop unnecessary non-null assertions flagged by CI lint.
joaner
force-pushed
the
fix/lint-pointcloud-v1.7.2
branch
from
e5a9727 to
a1b02ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
camera/controls/invalidateref sync out of render intouseEffectto satisfyreact-hooks/refs.pointCloud.ts/pointCloud.test.tsflagged by@typescript-eslint/no-unnecessary-type-assertion.v1.7.2Release validate job.Test plan
npm run lintnpx vitest run src/shared/utils/pointCloud.test.ts