Libvirt: Check access to system QEMU socket - #3877
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
act_probe still uses virsh list without -c qemu:///system, which can query a different libvirt instance and produce misleading results.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the libvirt provider preflight probe to explicitly validate access to the system libvirt/QEMU connection (qemu:///system), aligning the check with system-wide libvirt networking usage.
Changes:
- Update the libvirt networking probe command to use
virsh -c qemu:///system net-list. - Refine the associated error message to clarify it’s checking system-wide virsh networking access.
File summaries
| File | Description |
|---|---|
netsim/providers/libvirt.yml |
Adjusts the provider probe to test permissions against the system libvirt URI for networking. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.