Conversation
isaacs
force-pushed
the
isaacs/rm-cwd
branch
2 times, most recently
from
March 4, 2026 00:43
59359ac to
cce8085
Compare
When removing any path that has `..` or `.` as path portions, call `path.normalize` on the path before attempting to process it. When removing the path `''`, throw a `stat ENOENT` error. When removing `.`, replace with `process.cwd()` and proceed as normal. Also, add support for deleting `file:` URLs and Buffer paths, which are normalized to `string` for the benefit of older Node versions. Glob patterns must still be normal `string` values. This mirrors the behavior of node, once nodejs/node#61968 lands. Closes: #342 Fixes: #326 Re: nodejs/node#61958 Credit: @abhu85, @RajeshKumar11, @isaacs
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When removing any path that has
..or.as path portions, callpath.normalizeon the path before attempting to process it.When removing the path
'', throw astat ENOENTerror.When removing
., replace withprocess.cwd()and proceed as normal.Also, add support for deleting
file:URLs and Buffer paths, which arenormalized to
stringfor the benefit of older Node versions.Glob patterns must still be normal
stringvalues.This mirrors the behavior of node, once nodejs/node#61968 lands.
Closes: #342
Fixes: #326
Re: nodejs/node#61958
Credit: @abhu85, @RajeshKumar11, @isaacs