test: lock in correct handling of drive-letter paths on win32 - #373
Open
prajwal-raj wants to merge 1 commit into
Open
prajwal-raj wants to merge 1 commit into
prajwal-raj wants to merge 1 commit into
Conversation
Refs isaacs#325. pathArg already excludes the drive prefix (e.g. C:\) from the illegal-character check via path.substring(root.length), but there was no test asserting valid drive-letter/UNC paths pass without throwing, only that bad ones fail. This adds that coverage and locks in the current correct behavior.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #325. pathArg already excludes the drive prefix (e.g. C:) from the illegal-character check via path.substring(root.length), but there was no test asserting valid drive-letter/UNC paths pass without throwing, only that bad ones fail. This adds that coverage and locks in the current correct behavior.